Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): add missing semver dependency #472

Merged
merged 2 commits into from
Nov 1, 2019
Merged

fix(core): add missing semver dependency #472

merged 2 commits into from
Nov 1, 2019

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 31, 2019

Which problem is this PR solving?

#471

Short description of the changes

  • add missing semver dependency

@codecov-io
Copy link

codecov-io commented Oct 31, 2019 •
edited
Loading

Codecov Report

Merging #472 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   94.93%   94.88%   -0.05%     
==========================================
  Files         131      131              
  Lines        6635     6554      -81     
  Branches      565      561       -4     
==========================================
- Hits         6299     6219      -80     
+ Misses        336      335       -1
Impacted Files Coverage Δ
...ges/opentelemetry-exporter-zipkin/src/transform.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-zipkin/test/zipkin.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-plugin-dns/test/utils/assertSpan.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️
...try-plugin-dns/test/functionals/dns-enable.test.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-zipkin/test/transform.test.ts 100% <0%> (ø) ⬆️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 60% <0%> (+2.85%) ⬆️

@OlivierAlbertini OlivierAlbertini added the bug Something isn't working label Oct 31, 2019
@mayurkale22 mayurkale22 merged commit 283458e into open-telemetry:master Nov 1, 2019
@mayurkale22 mayurkale22 mentioned this pull request Nov 1, 2019
Closed
@dyladan dyladan mentioned this pull request Nov 20, 2019
Closed
6 tasks
@Flarna Flarna deleted the core-dependencies branch December 13, 2019 20:58
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@svrnm @vmarchaud
docs: Explicitly state that express instrumentation does not export s…
829f09f 
…pans without http instrumentation (open-telemetry#472)

As discussed in the meeting today, I think making this point clear helps enduser to understand what they _might_ be doing wrong if no spans are exported.

Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkhan danielkhan danielkhan approved these changes

@OlivierAlbertini OlivierAlbertini OlivierAlbertini approved these changes

@markwolff markwolff markwolff approved these changes

@mayurkale22 mayurkale22 mayurkale22 approved these changes

@bg451 bg451 Awaiting requested review from bg451

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dyladan @codecov-io @danielkhan @OlivierAlbertini @markwolff @mayurkale22